- Jan 18, 2024
-
-
Yohei Yukawa authored
Historically RemoteInputConnectionImpl has been calling on InputMethodManager#isActive() to see if the InputConnection is considered to be active or inactive when actually handling each incoming InputConnection operation. However, InputMethodManager#isActive() is also known to be tricky because it internally calls InputMethodManager#checkFocus(), which can have non-trivial side effects. With this CL, RemoteInputConnectionImpl keeps maintains its own boolean state on whether #deactivate() is already called or not so that it does not need to rely on IMM#isActive() any more. For 99% cases there must be no observable behavior change, and for the remaining 1% cases the new behavior should be more easily understandable. Bug: 291826769 Test: atest CtsInputMethodTestCases:InputConnectionHandlerTest#testInputConnectionSideEffect Merged-In: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8 Change-Id: I2fb9c549da19ff01e7cc3fd8bfc1f9c19aa0f0a8
-
Yohei Yukawa authored
With my previous CLs [1][2], we can generally assume the following things. - InputConnection#closeConnection() always gets called when it becomes invalidated, including the case when the IME has switched to another IME client. - Each implementation of InputConnection#closeConnection() is expected to do appropriate clean up including finishing composing text. {Base,Editable}InputConnection actually do this correctly. With that it should be safe for #finishComposingText*() to follow the same pattern about isActive(). [1]: I234309c5880c9fe0b299b8bd0f8862796d4dda0d 9f9afe52 [2]: If2a03bc84d318775fd4a197fa43acde086eda442 aaa38c9f Bug: 35301295 Bug: 291826769 Test: presubmit Merged-In: If913701bf8555f5d76fceb272e38a99f5e243bbe Change-Id: If913701bf8555f5d76fceb272e38a99f5e243bbe
-
Yohei Yukawa authored
It is guaranteed that the following two boolean expressions have always the same value observed outside from RemoteInputConnectionImpl#mLock. A. RemoteInputConnectionImpl#mFinished B. RemoteInputConnectionImpl#mInputConnection != null With that we should be able to simply merge them into an atomic reference object AtomicReference<InputConnection> without requiring RemoteInputConnectionImpl#mLock as a lock object. This CL does so as a preparation to clean up RemoteInputConnectionImpl for Bug 291826769. There should be no observable behavior change, except for the fact that RemoteInputConnectionImpl#dumpDebug() no longer blocks other operations that required mLock, which is kind of out of our original intention. Bug: 291826769 Test: presubmit Merged-In: I69fa2c81670f84be3dd4a808262758a803f69dfc Change-Id: I69fa2c81670f84be3dd4a808262758a803f69dfc
-
- Jan 17, 2024
-
-
Shawn Willden authored
Bug: 290312729 Test: N/A Change-Id: I65e7ce4b7113639523aec1e08682a334056cbb69
-
- Jan 16, 2024
-
-
Sihua Ma authored
This helps fix issues with improper layouts of adapter child views in case RemoteCollecionItemsAdapter is used. Test: Manual Bug: 245950570 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dc464d6e522eebec5221a934ec3ff5f52a4fb90e) Merged-In: I0eedf4574975bfae88801e0153816135fc1c8181 Change-Id: I0eedf4574975bfae88801e0153816135fc1c8181
-
- Jan 15, 2024
-
-
wilsonshih authored
To make the embedded window of SplashScreenView non-focusable, needs to add the window flag separately from SurfaceControlViewHost#setView Bug: 319369153 Test: verify the embedded window of splash screen won't grant focus Change-Id: Ic9b48dcc4de25e681405b3dd78468597a8a7c627
-
- Jan 13, 2024
-
-
Aaron Vaage authored
Change-Id: Ib79857aa0c6bdf76d0ab65cd66e044aac4e4084e
-
- Jan 11, 2024
-
-
Yan Yan authored
This CL integrates the IpSecPacketLossDetector into VCN route selection. With this change, when a data stall is reported, the network candidate will be penalized and then deprioritized during network selection. A network candidate will stop being penalized until it hitting a timeout or passing the validation. Bug: 282996138 Test: atest FrameworksVcnTests(new tests), CtsVcnTestCases Change-Id: Ifabd6fdea1d5a4fea40cf929dbab7c26d37274ac
-
Tom Chan authored
syntax from go/android-codereviews#include-an-owners-file-from-a-sub-directory-within-the-same-git-project Change-Id: Ia02a5efdda1c2dea65753a63cbd2e78e56bac6eb
-
- Jan 10, 2024
-
-
Yan Yan authored
This CL creates an abstract class NetworkMetricMonitor and a subclass IpSecPacketLossDetector. IpSecPacketLossDetector is responsible for continuously monitoring IPsec packet loss and reporting to the caller when the data loss rate surpass a threshold. This detector allows the VCN to switch from the underlying network that has bad quality. This CL also defines new carrier configs that specify the data loss threshold and detecting frequency Bug: 282996138 Test: atest FrameworksVcnTests(new tests), CtsVcnTestCases Change-Id: I5f4b8e1821bdbb37f0a6de6e1584f8e3c87273f3
-
William Loh authored
Bug: 307556883 Test: n/a Change-Id: I2836908a00981d54e884a495a662bc293219c0e4
-
- Jan 09, 2024
-
-
Alisher Alikhodjaev authored
(Discovery tech and Change Routing) Bug: 300351519 Bug: 319156577 Test: n/a Merged-In: If664910d00fc673c0329e0cd4489174260eb4f1e Merged-In: I3035f8b4fac331d827afa8e7bda6109d91ee510a Change-Id: If664910d00fc673c0329e0cd4489174260eb4f1e
-
Sudheer Shanka authored
Bug: 317897994 Test: manual Change-Id: I806df54dd1f82d37998a37113faafbecd04adc10
-
- Jan 08, 2024
-
-
Yifan Hong authored
Before this change, if the kernel has a set of CONFIGs that is not compatible with the system image, a dialog is displayed for user / userdebug builds at boot time. This check has been doing more harm than good because: - This check is already enforced at build time and during VTS tests (See vts_treble_vintf_framework_test). - The dialog blocks UI automation for tests. For these UI automation tests, they need to respond to the dialog. - GKI has been enforced ecosystem-wide except for a few low-end devices of other verticals. For these non-GKI devices, the check enforced by VTS should guard this. Hence, the check does not give us any signal. - During development, a kernel that corresponds to the latest release (android15 as of now) might not have valid kernel config requirements in userspace. Kernel development schedule is usually ahead of the userspace development schedule. It does not always carry the string "-mainline-", because it is not a mainline kernel. To unblock test automation on these latest, bleeding-edge kernels, this kernel check should go away. - This is a small steps towards dropping the dependency on libvintf on libandroid_runtime. libvintf links to libselinux, which is huge. libandroid_runtime loads this, and the memory stays there forever. Ideally, we should disable the whole VINTF check at boot time, but let's do this one step at a time. Bug: 272479887 Bug: 270169217 Test: TH Change-Id: If24cdca9fb535b8f443c0d21f9a46c7ea25c1f9f
-
Yifan Hong authored
It is not used anywhere. Test: TH Bug: 270169217 Change-Id: Ifcc8412ed3629d2447908513faf1d6f5ed3f483c
-
- Jan 06, 2024
-
-
Yifan Hong authored
Non-A/B has been deprecated for long. During non-A/B updates, compatibility.zip is checked with VintfObject.verify(), which is another deprecated function that always returns compatible if a list of package VINTF XMLs are supplied. (see below.) Hence, the private RecoverySystem.verifyPackageCompatibility was just useless code that unconditionally returns true except for invalid ZIP file. Remove it. Replace the public RecoverySystem.verifyPackageCompatibility and make it return true unconditonally. VintfObject.verify() with OTA XMLs are deprecated per http://b/139300422 [VINTF] Delete OTA vintf checking code in http://r.android.com/1194233 ("Delete VINTF compatibility checks during OTA."), in 2019. We had decided that compatibility checks during OTA should be removed, and moved to OTA generation time instead. Using an old libvintf on the device to check against new libvintf metadata required forward compatibility of libvintf, which cannot be achieved. Instead, the device should verify the signature of the OTA to verify its source. Test: TH Bug: 270169217 Bug: 139300422 Change-Id: I775d29e4cd1d165233e07cfb820d1fe343fa4757
-
- Jan 05, 2024
-
-
Eric Biggers authored
Remove the serialNumber parameter from IStorageManager#prepareUserStorage, StorageManager#prepareUserStorage, and StorageManagerService#prepareUserStorageInternal, as it is not used. Bug: 316035110 Test: atest UserDataPreparerTest Flag: N/A, mechanical refactoring Change-Id: I4bb716a502fec267fbe0d93e423c7d713c78feaa
-
Eric Biggers authored
Remove the serialNumber parameter from IStorageManager#createUserStorageKeys and StorageManager#createUserStorageKeys, as it is not used. Bug: 316035110 Test: presubmit Flag: N/A, mechanical refactoring Change-Id: I11f2507fefb374bea7c8de857424c67108fcb97e
-
Eric Biggers authored
Remove the serialNumber parameter from IStorageManager#unlockCeStorage, as it is not used. Bug: 316035110 Test: atest UserControllerTest Test: atest com.android.server.locksettings Flag: N/A, mechanical refactoring Change-Id: Idfb46e625f0ab6915c980e4a39420fe712cb5fb5
-
Edward Savage-Jones authored
Add/update owners for SystemConfig related files (See comment in: https://r.android.com/2775452) c/j/c/a/s/SystemConfig.java has also moved so update the OWNERS file for that too. Change-Id: Ia773c7851d6aad4223ce5845d0993d527a5fd140
-
Edward Savage-Jones authored
Prevent the disabling of specified apps, avoiding cases where disabling the app may result in an unusable system. Bug: 200043113 Change-Id: I5b0ed8c34a40428e8d18072582e46854737c000a
-
- Jan 04, 2024
-
-
Pawan Wagh authored
Test: m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk Test: atest SettingsProviderTest Bug: 295035851 Bug: 294614538 Change-Id: I7bba46c39d609f314e17eb861341bd599b192612
-
Pawan Wagh authored
Test: m framework-all Test: Compiled and applied OTA using settings app using stable interface m Settings && adb install -r $ANDROID_PRODUCT_OUT/system_ext/priv-app/Settings/Settings.apk Bug: 317914533 Change-Id: I393df5218c60303dbea60386c680b75b553ddac2
-
Alexei Nicoara authored
Change-Id: Icc8a7b899ccb54196ece9cccbfe3658547f0603c
-
- Jan 03, 2024
-
-
Yan Yan authored
Bug: 317406085 Test: atest FrameworksVcnTests(new tests), CtsVcnTestCases Change-Id: I8f5b6cb4e8286331626d4d39b864f0298657cab6
-
Peiyong Lin authored
Toast message should have a target package that receives and resolves the intent, otherwise it will be sent to all components in all packages which could result in crashes. Bug: b/318460567 Test: manual Change-Id: I9918ae7d273aa0bda6a39294bba878d9b58cf1b5
-
Sooraj Sasindran authored
Bugs: 307559608 Change-Id: I0c600c1a8c96fef4d820e41a6188862672f535af
-
- Jan 02, 2024
-
-
Azhara Assanova authored
Bug: 293467489 Test: tested on device Change-Id: I1abb2b880a37f18c0a5e28c4e22d739703d1f20a Merged-In: I277458bb1f6d7ece1f9efc8054a8d3d9b3924000
-
- Dec 21, 2023
-
-
Alisher Alikhodjaev authored
Bug: 317293523 Test: manual Change-Id: Ief04be69ad420f55b139033bf59467c62e6bc975
-
Devin Moore authored
Test: launch_cvd Bug: 218588089 Change-Id: Ifeb615dccbac68eb050c340bc8809cd07a89dc6f
-
- Dec 20, 2023
-
-
John Johnson authored
Test: repo still builds Bug: 306203494 Change-Id: I3983801865a6b8cd9aba04c24a52f9bb2b1d7577
-
- Dec 18, 2023
-
-
Mark Punzalan authored
Test: Presubmit only Bug: 297373084 Merged-In: I499b6a99e53775abf084f741802463940730091a Change-Id: I499b6a99e53775abf084f741802463940730091a
-
Jeremy Meyer authored
Test: automated Bug: 117306409 Merged-In: If3a3de2325de0c31ebe92ab41631869008425728 Change-Id: If3a3de2325de0c31ebe92ab41631869008425728
-
Alex Xu authored
Bug: 309649371 Test: N/A Change-Id: I4adff5cd92042208fa2d695423fdfa0072f916b2
-
George Chan authored
Test: N/A Change-Id: I99744ca971281130dbe57626882ac10e382ea949
-
- Dec 14, 2023
-
-
T.J. Mercier authored
This reverts commit 4a11b111. This change was originally reverted due to a bug in the child commit of a change in the same topic which caused process group kills not to occur when using cgroup.kill. Now that has been fixed, bring back this change with the fix. Bug: 301871933 Change-Id: I81dde53f21ba2e01c01dfd5f7009ea1ef690b582
-
Steven Moreland authored
Bug: 297833427 Test: N/A Change-Id: I8bd480d7deb74062f3aaf61f30b1335443f82653
-
- Dec 13, 2023
-
-
Roshan Pius authored
Rename from `isOtherServiceEnabled` to `isCategoryOtherServiceEnabled`. Bug: 315130804 Test: Compiles Change-Id: I7b97b6de0bd702e695557a4d55a1f80e612f92c8
-
Roshan Pius authored
Add @IntDef to return values of getAdapterState. Bug: 315228674 Test: Compiles Change-Id: I8134a68c36950e89cd65c2b4ab9dd9cefb2cb7b4
-