Skip to content
Snippets Groups Projects
  1. Feb 11, 2021
    • Hai Zhang's avatar
      Fix privapp permission allowlisting. · e391b193
      Hai Zhang authored
      The refactoring in S unintendedly introduced a change that allowed
      signature|privileged to be granted to platform-signed privileged apps
      without being in the allowlist XML, so we should revert to the old
      behavior.
      
      The refactoring was done in the hope that we can have one step that
      handles privileged permission granting. However upon retrospection, we
      have to do this in two separate steps because the privapp permission
      allowlist should always be enforced first.
      
      This change reverts to the old behavior by looking at both the current
      code and the R source code, then extracts the privapp permission
      enforcement as a separate step that happens first, to be used by both
      signature and the new internal permission protection.
      
      Also simplified the check about privileged permission, because vendor
      privileged permission is always a privileged permission, as made sure
      in PermissionInfo.fixProtectionLevel().
      
      In the mean time, added the missing privapp permission allowlist entry
      for Settings and RESTART_WIFI_SUBSYSTEM for device to boot.
      
      Fixes: 179309876
      Test: manual
      Change-Id: I93cfe7a4621fc5ac65229d42c7a8ebd825ae8ae5
      e391b193
  2. Feb 09, 2021
  3. Feb 08, 2021
    • Christian Frank's avatar
      Add MANAGE_MUSIC_RECOGNITION to privapp permissions. · 517052bf
      Christian Frank authored
      (Permission will be migrated to a role in a follow-up).
      
      Bug: 178644109
      Test: atest CtsPermission2TestCases:android.permission2.cts.PrivappPermissionsTest#privappPermissionsNeedToBeWhitelisted -- --abi arm64-v8a
      Change-Id: I491450d8748ac669a017547ffb8616e2544aa397
      (cherry picked from commit 6fa6344e)
      517052bf
  4. Feb 05, 2021
    • Yuncheol Heo's avatar
      Give INTERACT_ACROSS_USERS permission to audioserver · 5f3f9ce6
      Yuncheol Heo authored
      - gcar_emu_x86_64 starts to crash after commit 1dafc385 is merged.
      
      Bug: 179455284
      Test: Build gcar_emu_x86_64 and check if it boots successfully.
      Change-Id: I59dad57c846e3a83d71abb58fdd5e57019d99e75
      5f3f9ce6
    • Nicholas Ambur's avatar
      add shell user allowlist perms for Asistant GTS · 3350b7a9
      Nicholas Ambur authored
      Origional changes were in aosp/1546877. It has a merged-in referencing
      ag/13319676, but ag/13319676 doesn't contain these changes. This CL is
      to add the missing changes.
      
      Bug: 177271291
      Test: gts-tradefed run gts -m GtsAssistIntentTestCases
      Change-Id: I22a3e6a3475263ec4e007e37412a269ca95c8bbe
      3350b7a9
  5. Feb 04, 2021
    • Kholoud Mohamed's avatar
      Grant shell QUERY_USERS and MODIFY_QUIET_MODE · 19b39a8f
      Kholoud Mohamed authored
      Added a new permission QUERY_USERS, granted the
      new permission and MODIFY_USERS to shell.
      These permissions are required to enable CTS
      tests to access the following APIs:
      * UserManager#getUsers and any other API that depend on it
      * UserManager#getProfileParent
      * UserManager#requestQuietModeEnabled
      
      Test: Confirmed that a CTS test can call these APIs
      Bug: 178695365
      Merged-In: Ifa14d24ee1873161e3986e8d0669fd47a7bcaa7a
      Change-Id: Ifa14d24ee1873161e3986e8d0669fd47a7bcaa7a
      19b39a8f
    • Winson Chung's avatar
      Revert "Sandbox letterbox and size compat apps" · 0ba61856
      Winson Chung authored
      This reverts commit 4d3f1c56.
      
      Reason for revert: b/179308296
      
      Change-Id: Idccf97038d5aa92268a13bacc512215878e8aefa
      0ba61856
    • Kholoud Mohamed's avatar
      Grant shell QUERY_USERS and MODIFY_QUIET_MODE · c60281bd
      Kholoud Mohamed authored
      Added a new permission QUERY_USERS, granted the
      new permission and MODIFY_USERS to shell.
      These permissions are required to enable CTS
      tests to access the following APIs:
      * UserManager#getUsers and any other API that depend on it
      * UserManager#getProfileParent
      * UserManager#requestQuietModeEnabled
      
      Test: Confirmed that a CTS test can call these APIs
      Bug: 178695365
      Change-Id: Ifa14d24ee1873161e3986e8d0669fd47a7bcaa7a
      c60281bd
  6. Feb 03, 2021
    • Naomi Musgrave's avatar
      Sandbox letterbox and size compat apps · 4d3f1c56
      Naomi Musgrave authored
      Sandbox Display#getRealSize and WindowManager
      bounds when letterbox or size compat mode are
      applied to the configuration. Display uses
      this field to provide the sandboxed display
      size.
      
      Test: atest WindowConfigurationTests
      Test: atest FrameworksMockingCoreTests:android.view.DisplayTests
      Test: atest WmTests:SizeCompatTests
      Bug: 171386167
      Change-Id: I6f78edcd9214b52ab0708e3892bc86ee05bb5b9a
      4d3f1c56
  7. Feb 02, 2021
    • Evan Severson's avatar
      Remove mic/camera permission split · 7ce41c10
      Evan Severson authored
      Apps can't request this permission anyways so some apps started
      misbehaving when forcing users to grant all permissions without caring
      what they are.
      
      Test: Boot
      Fixes: 172844303
      Bug: 158311343
      Change-Id: Ia83ad5433ff3cdae57d901b3a9d781725124c6b9
      7ce41c10
  8. Jan 30, 2021
  9. Jan 29, 2021
  10. Jan 27, 2021
    • Collin Fijalkovich's avatar
      Introduce TracingServiceProxy System Services · a5ceac11
      Collin Fijalkovich authored
      Introduces a new SystemService to act as intermediary between the
      Perfetto trace daemon and Traceur.
      
      Bug: 175591887
      Test: adb shell service call 1 i32 0/1
      
      Change-Id: Idea7761a8479827f0cfa561e56ba2beac3072939
      a5ceac11
    • Fan Zhang's avatar
      Cherry-pick I111dbda3418edf4fcf34aa26f39dc6ce662f2e5d · e7ce67f4
      Fan Zhang authored
      Pre-grant START_ACTIVITIES_FROM_BACKGROUND to emergency app
      
      The emergency app needs this permission to start foreground service
      after sdk 31.
      
      Fix: 172364084
      Test: manual
      Change-Id: I111dbda3418edf4fcf34aa26f39dc6ce662f2e5d
      (cherry picked from commit fb001c98)
      e7ce67f4
  11. Jan 26, 2021
  12. Jan 22, 2021
    • Makoto Onuki's avatar
      Add priv-permissions to the allowlist. · 83e38b24
      Makoto Onuki authored
      Bug: 177920807
      Test: atest CtsPermission2TestCases:android.permission2.cts.PrivappPermissionsTest#privappPermissionsNeedToBeWhitelisted -- --abi arm64-v8a
      Change-Id: I01d60ff89ee2eb38bab37a1d00c5e81bd6a06c01
      83e38b24
    • Etan Cohen's avatar
      Revert "Grant shell permissions for Airplane Mode to Shell to support CTS" · f357a045
      Etan Cohen authored
      This reverts commit ddb49025.
      
      Change-Id: I7d5433bf676661ede208f840c27a71abbe663195
      f357a045
    • Etan Cohen's avatar
      Grant shell permissions for restart WiFi subsystem to Shell to support CTS · d8d9e9c0
      Etan Cohen authored
      New permission is needed to allow CTS to trigger the new WiFi subsystem
      restart API.
      
      Bug: 175084231
      Bug: 178125790
      Test: atest android.net.wifi.cts.WifiManagerTest#testRestartWifiSubsystem
      Change-Id: I0eb0362e6421480c10ba64f923a9069d1258d4ca
      d8d9e9c0
    • Dan Harms's avatar
      Remove bundled CompanionDeviceSupport permissions · c7a0cefd
      Dan Harms authored
      Bug: 160037666
      Test: m
      Change-Id: Ib96198a39c18a0b9c3cf64c0c58c89b1a5b62c19
      c7a0cefd
    • Adam Bookatz's avatar
      UserSystemPackageInstaller auto-treats static overlays · 1f04060b
      Adam Bookatz authored
      The UserSystemPackageInstaller installs packages on new users
      based on their configuration in an allowlist. An exception was
      made for auto-generated RROs, which were instead installed based
      on their overlay target package's configuration (thus avoiding
      the need for manually allowlisting each such overlay).
      
      This is now expanded to all static overlays (which should
      include auto-generated RROs, according to the bug). That is:
      Static overlays no longer need to be mentioned in the list,
      but will instead be installed based on the listing for their
      overlay target package.
      
      Test: atest UserSystemPackageInstallerTest
      Fixes: 172956245
      Change-Id: I6b974bba20ee059a8f744092db7c3441580d327f
      1f04060b
  13. Jan 21, 2021
    • Dan Harms's avatar
      Remove bundled CompanionDeviceSupport permissions · 25aa649c
      Dan Harms authored
      Bug: 160037666
      Test: Compiles
      Change-Id: I955916f97815fb55a4e701f69a01a975e0d0c205
      Merged-In: Ib96198a39c18a0b9c3cf64c0c58c89b1a5b62c19
      25aa649c
    • Jordan Liu's avatar
      Add BROADCAST_CLOSE_SYSTEM_DIALOGS to allolist for cbr · 67043d59
      Jordan Liu authored
      Bug: 177346942
      Test: manual
      Change-Id: Icc512fd8e205bdc6645558053f254e2b39bea077
      67043d59
    • Keun young Park's avatar
      Change target package for com.android.car.shell · ffdc3f06
      Keun young Park authored
      - It now overrides shell package itself
      
      Bug: 177099512
      Test: Check if shell package has all necessary permissions
      Change-Id: I139b47fcb2992e42da020aaac8680ae8dd2efac0
      Merged-In: I139b47fcb2992e42da020aaac8680ae8dd2efac0
      (cherry picked from commit 2bd010b7)
      ffdc3f06
    • Jeff Vander Stoep's avatar
      Add alanstokes@ to privileged permissions OWNERS · 6e303194
      Jeff Vander Stoep authored
      Test: n/a
      Change-Id: Ic4ffafeb36d2bc69ebdd39e3f8ff40547bdcddd3
      6e303194
    • Charles Chen's avatar
      Creates WindowToken for WindowContext · 8cb66757
      Charles Chen authored
      ...  until it adds the first view
      
      In R, we create WindowToken for every WindowContext creation.
      In S, we only create WindowToken for the WindowContext which adding
      a view.
      This CL also provide the ability to attach an existing WindowToken
      by overriding WindowManager.LayoutParams.mToken, and remove the
      WindowContext created WindowToken after WindowContext destruction.
      
      Bug: 159767464
      Bug: 153369119
      Test: atest WindowTokenTests WindowContextListenerControllerTests
      Change-Id: Iefe0315461b452a84cecbff2d08ee04c1f34051d
      8cb66757
  14. Jan 20, 2021
    • Bernardo Rufino's avatar
      [Attempt #2] Add privileged to BROADCAST_CLOSE_SYSTEM_DIALOGS · 5e390e79
      Bernardo Rufino authored
      Original CL got reverted because target aosp_arm64-userdebug was failing
      to boot. Apparently, the right place to put the permission for launcher3
      is in frameworks/base/data/etc/com.android.launcher3.xml, not
      frameworks/base/data/etc/privapp-permissions-platform.xml (despite it
      having an entry on the latter) because launcher3 lives in system_ext.
      
      -- Original CL description
      
      CellBroadcastReceiver, a mainline module signed with the networkstack,
      needs it before showing emergency alerts to the user.
      
      This is inline and ok with the rest of of the restrictions given that
      STATUS_BAR that allows calls to StatusBarManager.collapsePanels() also
      has "privileged" protection level.
      
      Also adding permission to privapp-permissions-platform for Launcher3
      because of b/177506944, despite it getting it via "recents" protection
      level.
      
      Bug: 177346942
      Bug: 159105552
      Test: atest PermissionPolicyTest
      Test: Run DeviceBootTest for aosp_arm64-userdebug in forrest.
      Change-Id: Ie3298c839003aeaca3cc84782e8846374beca5b8
      5e390e79
    • Ivan Chiang's avatar
      Revert "Add privileged to BROADCAST_CLOSE_SYSTEM_DIALOGS" · 0c2c8dab
      Ivan Chiang authored
      Revert "Add BROADCAST_CLOSE_SYSTEM_DIALOGS to launcher via privi..."
      
      Revert "Udpate BROADCAST_SYSTEM_DIALOGS permission in CTS"
      
      Revert submission 13328953-acsd-privileged
      
      Reason for revert: DeviceBootTest#REBOOT_TEST fail on b/177952808.
      Reverted Changes:
      Id3fdaf36f:Udpate BROADCAST_SYSTEM_DIALOGS permission in CTS
      I40a28210f:Add BROADCAST_CLOSE_SYSTEM_DIALOGS to launcher via...
      If027c6824:Add privileged to BROADCAST_CLOSE_SYSTEM_DIALOGS
      
      Change-Id: I2a2e12af9075727e0d6f0be07467c4ba9285b2d3
      0c2c8dab
    • Hall Liu's avatar
      Add new columns in CallLog · 6b7885f1
      Hall Liu authored
      Add new column definitions in the call log db to support storing the new
      call composer elements in the call log. Also refactor addCall to use a
      builder pattern, and add READ_VOICEMAIL for shell in order to support
      new CTS tests
      
      Test: atest CallLogTest
      Bug: 174798736
      Change-Id: I00e127510c382d9ff0ffc70f4c5ad7179ac7319a
      6b7885f1
  15. Jan 19, 2021
    • Nathalie Le Clair's avatar
      Map power button on reference remote to KEYCODE_TV_POWER · eaad5f35
      Nathalie Le Clair authored
      After this change, the power button on the reference remote will function
      as a power toggle for the HDMI-connected display (=TV) power state. The
      device will then follow the TV power state.
      
      Bug: 157402294
      Test: N/A
      Change-Id: I462f792f5aae8c47c876d3ea3dfea64fc1c551b5
      eaad5f35
  16. Jan 15, 2021
  17. Jan 14, 2021
    • Heemin Seog's avatar
      DO NOT MERGE Remove floating cards launcher · 7c963eaa
      Heemin Seog authored
      Bug: 177364704
      Test: none
      Change-Id: I8f19d7d58ee78b64d93de265739a7a880b6a52df
      7c963eaa
    • Bernardo Rufino's avatar
      Add privileged to BROADCAST_CLOSE_SYSTEM_DIALOGS · 4d62bdba
      Bernardo Rufino authored
      CellBroadcastReceiver, a mainline module signed with the networkstack,
      needs it before showing emergency alerts to the user.
      
      This is inline and ok with the rest of of the restrictions given that
      STATUS_BAR that allows calls to StatusBarManager.collapsePanels() also
      has "privileged" protection level.
      
      Also adding permission to privapp-permissions-platform for Launcher3
      because of b/177506944, despite it getting it via "recents" protection
      level.
      
      Bug: 177346942
      Bug: 159105552
      Test: atest PermissionPolicyTest
      Change-Id: If027c6824a58c8b9a917f9995e34bf8b306cab54
      4d62bdba
  18. Jan 13, 2021
  19. Jan 12, 2021
    • Adam Bookatz's avatar
      Add User* OWNERS file (part 2) · 6cd4cd01
      Adam Bookatz authored
      Part 1 was aosp/1546301.
      Two parts are required due to b/175318571.
      
      Test: N/A
      Change-Id: I1a89f7d26da70dce36d1e891a8e8ebc4042dc56c
      6cd4cd01
  20. Jan 11, 2021
    • Keun young Park's avatar
      Change target package for com.android.car.shell · 2bd010b7
      Keun young Park authored
      - It now overrides shell package itself
      
      Bug: 177099512
      Test: Check if shell package has all necessary permissions
      Change-Id: I139b47fcb2992e42da020aaac8680ae8dd2efac0
      2bd010b7
    • Michael Groover's avatar
      Whitelist READ_PRIVILEGED_PHONE_STATE for the contacts provider · 1c1bc30c
      Michael Groover authored
      In Android 10 access to device identifiers was moved from a runtime
      permission to the privileged READ_PRIVILEGED_PHONE_STATE permission.
      One of the non-resettable identifiers missed was SubscriptionInfo#
      getIccId. The contacts provider currently uses this ID to upgrade
      to version 1003 of the database; to ensure there are no issues with
      this upgrade this permission is being whitelisted for the contacts
      provider.
      
      Bug: 131909991
      Bug: 173421434
      Test: atest ContactsProviderTests
      Change-Id: I7574f787a7e55aa0337237b9fe916ee143a2f697
      Merged-In: I7574f787a7e55aa0337237b9fe916ee143a2f697
      1c1bc30c
  21. Jan 06, 2021
    • Jordan Liu's avatar
      Update allowlist for shell and BIND_CARRIER_SERVICE · dac5abcd
      Jordan Liu authored
      Bug: 175043978
      Test: atest PrivappPermissionsTest#privappPermissionsNeedToBeWhitelisted
      Change-Id: I4153770218c0cae39882b80266183d74af6622fe
      dac5abcd
    • Collin Fijalkovich's avatar
      Allow Traceur to take START_FOREGROUND_SERVICES_FROM_BACKGROUND · 89ff2a3f
      Collin Fijalkovich authored
      As part of targetting the Android S API level, we need to explicitly
      allow the privapp Traceur to start services from the background.
      
      Test: atest TraceurUiTest
      Bug: 176849372
      Change-Id: I58c2a23653541f8516beedf0971d60403eedbb02
      89ff2a3f
    • Evan Rosky's avatar
      Add per-change flags and wallpaper windows to transitions · dba8bbfd
      Evan Rosky authored
      This CL adds flags per-change in a transition so that
      extra meta-information (like is-wallpaper, shows-wallpaper,
      translucent, starting-window-transfer) can be passed to
      shell.
      
      This then treats wallpaper like other activities WRT to
      transitions (collect/send to shell) except for a couple
      differences:
      1. When any window is collected, if it shows wallpaper, then
         the wallpaper will be automatically collected too.
      2. During TransitionInfo construction, wallpaper containers
         are excluded from promotion and root-leash calculation.
      
      This also adds starting-window transfers to the transition
      and adds support in the example player.
      
      Bug: 169035082
      Test: launch any non-wallpaper app (eg. messages), then press
            home-button to bring home to front. The wallpaper should
            be included with the home fading-in.
      Change-Id: I7ceea614e16c2686f533937db10436f66764255e
      dba8bbfd
  22. Jan 05, 2021
    • Max Zhang's avatar
      Add key layout and device file for Reference RCU · c8ae8840
      Max Zhang authored
      Adding key layout and device configuration file
      for Google Reference RCU.
      The VID/PID pair used in file name is speicifically for
      Reference RCU, which supports both G10 and G20.
      
      b/173100313
      test: manually on custom build for ADT-3
      
      Change-Id: I2048012fb91adfc6a2f61065ba262d5ed344c673
      c8ae8840
Loading