- Apr 05, 2018
-
-
Treehugger Robot authored
-
Dmitry Shmidt authored
Bug: 75290651 Test: Manual Change-Id: I30bda23667ac911bf21da5705d248833f919f8bf Signed-off-by:
Dmitry Shmidt <dimitrysh@google.com>
-
Treehugger Robot authored
-
- Apr 04, 2018
-
-
Hansong Zhang authored
Remove the "HidDeviceCabled" flag from the config when the remote device is not currently being usec Bug: 77549256 Test: manual Change-Id: I2c88e972457608699c3f0344357828324a419b90
-
Treehugger Robot authored
-
- Apr 03, 2018
-
-
Ajay Panicker authored
Some carkits don't honor the fact that VFS ID's only are consistent to the folder they are currently browsing. Now a UID will remain valid until the connection ends. Bug: 68812037 Test: Run net_test_avrcp Change-Id: I67898277327b54eaeca2121b9ff173b22bd4ba71
-
- Apr 02, 2018
-
-
Ajay Panicker authored
The Now Playing List ID's could be invalid if the now playing list changes but there is not track change, like when adding a song to the queue on the device. Bug: 68812037 Test: Run host native test net_test_avrcp Change-Id: I3c2c11aa87b64241f378819c38ae5cc21ffdb5ac
-
Ajay Panicker authored
Bug: 77241554 Test: Run host native tests net_test_avrcp and net_test_btpacket Change-Id: If32aa506dc8f99220ef35efeb4d77a1023767afe
-
- Mar 30, 2018
-
-
Jack He authored
* Log every instance of RFCOMM unexpected disconnection * Log every time when RFCOMM channel (DLCI) is changed * Refactor some RFCOMM code to be more readable and easier for logging * Remove excessive logging in power manager * Assign HSP default version more appropriate location * Replace some usage of NULL with nullptr Bug: 77224743 Test: make, no functional changes Change-Id: I5e62dd6d338f7e92a8b8d39c1fe155b71396034c
-
Treehugger Robot authored
-
Treehugger Robot authored
* changes: AVRCP play status change updates AVRCP register for addressed player changed
-
Pavlin Radoslavov authored
For every periodic aptX / aptX HD data packet, use a single read operation for all PCM data that needs to be encoded, instead of using multiple reads of smaller blocks of data. Bug: 70899260 Test: Manual: stream to aptX/aptX HD headset, change the sample rate Change-Id: Ifcb8302589f24f5d7ab89c645c50d6905197fb7f
-
- Mar 29, 2018
-
-
Hansong Zhang authored
* setActiveDevice() returns false in error case, e.g. when the device is not connected * add getActiveDevices() instead of isActiveDevice(), which returns a list that must have two elements: left and right, or empty list on error Test: manual Bug: 69623109 Change-Id: I6f872dd88422e9d7e5187603d3ad33628726e1ca
-
Jakub Pawlowski authored
Test: compilation Change-Id: I66040a4f3d339ac0473052d916b9a0b4e3045e8e
-
Jakub Pawlowski authored
In bta_dm_remove_device, if the device is not connected, and we don't know the transport for given address, we make two calls to BTM_ReadConnectedTransportAddress, to determine the device address on the other transport. If the address provided is LE, first call will fill the other_address variable with the Classic address, and the second call will fill it back with LE addres. This mean we never try to remove Classic entry, instead we remove LE entry twice. Bug: 67907612 Test: establish LE connnection between two phones, trigger Bonding. After bonding complete, try to remove bond using LE address. Verify config file is cleaned of both LE and classic entry. Change-Id: Ia5dd53f96b95478a07009cecc5b4a3c79f15c59b
-
Treehugger Robot authored
* changes: Use proper media ID when changing path Add missing AVRCP Set Addressed Player Response
-
Ajay Panicker authored
Use the current media ID on the path stack to retrieve folder contents. Bug: 77237565 Test: run host native test net-test-avrcp Change-Id: I88d0862f76d18a071a8530cd31954447b4e180fc
-
- Mar 28, 2018
-
-
Ajay Panicker authored
Bug: 77237301 Test: run host native tests net-test-btpackets and net-test-avrcp Change-Id: Ic9a2c8d8cf5dd4c5be02a83975caa92e335ca2b9
-
Joseph Pirozzo authored
Process play status updates when seeking forward and backward. Bug: 67568875 Test: seek forward and backward on paired phone and observe updates. Change-Id: Id280f0e877cfea0a0da7603ab6d7bcfaf667d482
-
Treehugger Robot authored
-
Hansong Zhang authored
This reverts commit 87b96013. Reason for revert: Connected HID keyboard won't unpair Bug: 76907578 Test: SL4A Change-Id: I7d289183ac05b5f926c145799418461377228569
-
Pavlin Radoslavov authored
Previously, the default configured sample rate for aptX and aptX-HD was 44.1kHz. However, during AVDTP codec setup, the initial codec setup to 44.1kHz was followed immediately with automatic codec reconfiguration to 48.0kHz (if supported by the remote device) so the highest possible sample rate will be used. Changing the default sample rate to 48.0kHz eliminates the transient initial codec setup of 44.1kHz, because it is unnecessary and error-prone. Bug: 69276823 Test: Manual: connect to aptX / aptX-HD headsets and examine the AVDTP codec configuration in the btsnoop logs. Change-Id: I9e22365e0f07690c87503ea52fd9bb4d1ad4d5ff
-
Joseph Pirozzo authored
Register to be notified when the addressed media player changes so we can update the AVRCP controller. Bug: 72495854 Test: Change media player on phone, verify media source is updated. Change-Id: I932a25b9861734ecc6e1fdcf40f02cdde1fd049a
-
Joseph Pirozzo authored
Correct parameter order. Bug: 77009945 Test: observe log message Change-Id: I69d4bc04936c322707111c825864007b7f257cc4
-
Treehugger Robot authored
-
Treehugger Robot authored
-
- Mar 27, 2018
-
-
AnubhavGupta authored
Usecase: 1. Install Fitbit app 2. Pair and connect with RD1 3. Start streaming 4. Pair and connect Fitbit watch Failure: No Stable Avctp connection with Fitbit Watch after pairing Rootcause: If there will be no listening acceptor then some Remotes unable to connect AVRC connection upon remote restart. Fix: Open acceptor channel for RC on cleanup as if there will be no listening acceptor then some Remotes unable to connect AVRC connection upon remote restart. Test: 1. Install Fitbit app 2. Pair and connect with RD1 3. Start streaming 4. Pair and connect Fitbit watch Fixes: 63605621 Change-Id: Ia6cefc29ca64b00f2f5fe2f9816d71604c511415
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Srinu Jella authored
Steps: 1. Pair and connect with HID mouse. 2. Once the settings UI shows paired and connected 3. Try to unpair the device, but UI still shows connected. Failure: Unable to unpair HID mouse due to LMP response timeout occurred for remote version and remote feature request. Root Cause: Remote version, Remote features, Authentication requested commands go simultaneously to the remote device which can't handle the multiple commands at a time. Fix: Serialize the Remote version, Remote features, Authentication requested commands. Test: Tested manually with apple magic mouse. Bug: 35125883 Change-Id: I4448c291a60ee637dc5927806547e67f26571d86
-
Pavlin Radoslavov authored
If OTA A2DP codec configuration is accepted from the remote device, then don't trigger codec reconfiguration. Bug: 74521894 Test: Manual: accept connection and codec config from A2DP Sink Change-Id: Ic2f6ff08d130adf85cad68a54ab9fbc0a711534c
-
Pavlin Radoslavov authored
Use the existing mechanism for selecting the A2DP Source codec to select the A2DP Sink codec when the local device is A2DP Sink. * Added new method BtaAvCo::SelectSinkCodec() similar to SelectSourceCodec() and use the new method to select the actual codec based on the AVDTP Codec capability discovery. * Renamed method BtaAvCo::UpdateSelectableCodec() to UpdateSelectableSourceCodec() and added similar UpdateSelectableSinkCodec() * Renamed method BtaAvCo::AttemptCodecSelection() to AttemptSourceCodecSelection() and added similar AttemptSinkCodecSelection * Renamed AudioSinkHasContentProtection() to AudioSepHasContentProtection() because it can be used for either A2DP Source or Sink * Removed method BtaAvCo::FindPeerSourceSepForCurrentCodec() because it is not needed anymore. * Added new method A2dpCodecs::findSinkCodecConfig() similar to findSourceCodecConfig() * Added new function A2DP_SinkCodecIndex() similar to A2DP_SourceCodecIndex() * Added new method A2dpCodecs::setSinkCodecConfig() * Reorganize the SBC and AAC Source/Sink codec config classes: - Virtual method A2dpCodecConfig::setCodecConfig() is now implemented for Sink codecs as well: SBC Sink, AAC Sink - Renamed A2dpCodecConfigSbc to A2dpCodecConfigSbcSource - Renamed A2dpCodecConfigAac to A2dpCodecConfigAacSource - Added base class A2dpCodecConfigSbcBase. That class implements method setCodecConfig() for both A2dpCodecConfigSbcSource and A2dpCodecConfigSbcSink - Added base class A2dpCodecConfigAacBase. That class implements method setCodecConfig() for both A2dpCodecConfigAacSource and A2dpCodecConfigAacSink - Updated the A2dpCodecConfigAacBase::setCodecConfig() so it computes correctly the AAC Variable Bit Rate Support flag in the result codec config: The Variable Bit Rate Support is disabled if either side disables it. * Removed A2DP_BuildSrc2SinkConfig() because it is not needed anymore. The correspinding A2DP_BuildSrc2SinkConfigSbc() and A2DP_BuildSrc2SinkConfigAac() are removed as well. * Renamed a2dp_sbc_caps inside a2dp_sbc.cc to a2dp_sbc_source_caps * Renamed a2dp_aac_caps inside a2dp_aac.cc to a2dp_aac_source_caps * Added corresponding unit tests Bug: 74521894 Test: Manual: initiate connection from A2DP Sink. Unit tests in system/bt: test/run_unit_tests.sh net_test_stack Change-Id: I3fc541a068993c123e8d61c209896bb758fd3764
-
Jack He authored
* Store discovered HFP version to btif config file so that a reconnection session knows the HFP version before SDP * Check stored HFP version when RFCOMM channel is open before any AT command is processed * Set peer HFP version to 0 on control block allocation Bug: 67938255 Test: Connect with HFP 1.7 headsets Change-Id: I43e7aa04dee17ea7ba9e7d3992ec0860c11d23bc
-
- Mar 26, 2018
-
-
Jakub Pawlowski authored
Bug: 76217773 Change-Id: I50188e9c69dbcd42286097cb6fbc1aa715877c80
-
- Mar 24, 2018
-
-
Jakub Pawlowski authored
There is no functional change, just making the code pretty, and updating names to match 5.0 specification. Test: sl4a AdvertisingSetTest:test_reenabling Bug: 74198564 Change-Id: I1811e19bd18470adda55f7af7cfee23bcc4d1871
-
- Mar 23, 2018
-
-
Jakub Pawlowski authored
Fail on calls to ACPF when it's not supported in controller. Right now we sent such commands when starting/stopping the regular scan. Bug: 69116550 Test: Enable bluetooth on platform without ACPF, start/stop scan Change-Id: I334114d36a8af8c8f58d230f75ab3a00f009c4c5
-
Nitin Shivpure authored
Usecase: 1) Connect to HOGP device. (Because of some condition encryption fails with Connection Timeout, remote device turned off when connection was initiated) 2) Try to connect again to HoGP device Expected Result: Connection should be successful Observed Result: UI stuck in connecting state and connection never succeeds. Root cause: When encryption fails in previous iteration, encryption happens before HoGP Server starts security procedure, leading to Encryption Complete event being received with wrong status. Fix: Update the status to success when sending encryption complete event if link is already encrypted Test: Issue is not seen after above steps Fixes: 76133015 Change-Id: Ib404cf157289170ea300eae40f51393606c35105
-
Jakub Pawlowski authored
Bug: 75311714 Test: Test scenario described in bug Change-Id: Ib2da24134205277ae03cf28394db74758de17e5d
-
Jakub Pawlowski authored
Reject invalid data length for advertisement data. Also, don't attempt to resolve anonymous advertising addresses. Test: LE scanning tests Bug: 73193883 Change-Id: I1cb330bc30fdcaebc86527cd2656c9dd7932b318
-
Pavlin Radoslavov authored
Test: Code compilation Bug: 74952724 Change-Id: I022e16940c73181f991d528b9c96e2d26151369f
-