- Feb 19, 2024
-
-
Zhi Dou authored
If sdk_version is empty, by default the library will be built against the implementation of the framework jars. There are on going project to automatically repackaging flag libraries in the libray which is built direactly against the implementation of the framework jars. This change set the right sdk_version for the testing library. Bug: 310504781 Test: atest jarjar-rules-generator-test and CI Change-Id: I24d8dc47f7ed83f0b84c632d24396e2bdf932424
-
- Jan 31, 2024
-
-
Aditya Choudhary authored
This CL is created as a best effort to migrate test targets to the new android ownership model. If you find incorrect or unnecessary attribution in this CL, please create a separate CL to fix that. For more details please refer to the link below, <add g3 doc link> Bug: 304529413 Test: N/A Change-Id: I243f17b3f0ad7af9ffa15ca242456e36688733f5 Merged-In: I243f17b3f0ad7af9ffa15ca242456e36688733f5
-
- Mar 29, 2023
-
-
Patrick Rohr authored
This code has moved to external/cronet/android/tools/gn2bp. Test: none Change-Id: I3e95de24f01f01c937a223ae6cf501bc505f9de2
-
- Mar 24, 2023
-
-
Mohannad Farrag authored
* I've investigated turning off `allocator_shims` globally for all of Cronet but this didn't sound like a good option. allocator_shims are used for security measures, where sometimes malloc caller forget to check for NULL which happens on oom. allocator_shims would instantly kill the app instead of depending on the caller to do the validity check. * The solution here was to manually remove the files and add them to `android` and `glibc` only so allocator_shims is never compiled for musl. * Chromium does not support musl so there's no flag for `musl` with allocator_shims. Test: mma Change-Id: I2a63b14482a526d06a089647e6f61eea9f1691dc
-
- Mar 23, 2023
-
-
Mohannad Farrag authored
8484ec4d Change-Id: I490c09179ea6a20ca5fba83c314b552d360be688
-
Mohannad Farrag authored
Revert submission 2502135-remove_soong_namespace Reason for revert: Missing line needs to be added Reverted changes: /q/submissionid:2502135-remove_soong_namespace Change-Id: I780a21cf7031e04eb368fda4f93ed16ea032ca8d
-
Mohannad Farrag authored
* This was causing the infra to ignore the modules and masking build errors. Test: TH Change-Id: Ic5aa3557353488d5370f4d9c4240954820bfe52b
-
Motomu Utsumi authored
Bug: 273656868 Test: ./update_results.sh, TH Change-Id: Ieb8285b0308495c0cf2d9281ed54714280b7ebb0
-
- Mar 20, 2023
-
-
Chidera Olibie authored
Test: m Change-Id: I0ebd5f2d5566d12a1cf0136fcf3e588899757b7c
-
Chidera Olibie authored
Test: m cronet_aml_components_cronet_android_cronet_tests__testing Bug: 267353182 Change-Id: Ib2f555e3d36a5590387a282f4ce8c2ecca2f66d0
-
Mohannad Farrag authored
Test: None Change-Id: I5c32d3ec6e0e7351650896b96dd9f2755fe9ca1b
-
Chidera Olibie authored
Also adds soong_namespace to bp: cc: aosp/2493857 Test: th Bug: 274094720 Change-Id: Iddcfee5da5d155708ba164783242c9e1e13b070d
-
- Mar 14, 2023
-
-
Mohannad Farrag authored
* Some net files have different include_dirs for protos generated. If the generated file is at A/B/C/src/D/E. The net file expect the export include dir to be A/B/C/src/ Test: None Change-Id: I9ebe54094ea6bd2b00645be2bf724889dbcb3c1f
-
Mohannad Farrag authored
* Remove the python3 calls and replace them with the binary right away. * Fix action_foreach where sources can be used with {{source_file_name}} Test: None Change-Id: I0c2e6fd5135de70339168b9ba5d3b7f3a6866fdc
-
Mohannad Farrag authored
Apply https://chromium-review.googlesource.com/c/chromium/src/+/4166159 Test: None Change-Id: I297718dddd86a838367e86b8a0449d23114439b6
-
Mohannad Farrag authored
This reverts commit 379d79d1. Reason for revert: This is breaking the symbols of test library. Test: None Change-Id: I3a2e8a9a6ec6ce04038ed34489ece6a1ca053cef
-
Motomu Utsumi authored
For manual Android.bp change in aosp/2475845 Bug: 265674359 Test: ./update_results.sh Change-Id: Ie94708167479a67a52bbc1c7fd629a8206585cfd
-
- Mar 13, 2023
-
-
Stefano Duo authored
Use a more expressive always_disable function to disable unneeded third_party dependencies. Test: Android.bp.swp output is equivalent Change-Id: Ib21646dfa076fc6f745b7871851744d6ed18eaf3
-
Stefano Duo authored
Due to AOSP's FIPS requirements, AOSP-Cronet's BoringSSL must be built differently than Chromium-Cronet's BoringSSL. The downstream way of building BoringSSL is manually mantained in //external/cronet/third_party/boringssl. So, whenever a target depends on upstream's boringssl translate that to the downstream custom target. Test: m && CtsNetHttpTestCases Change-Id: I34a69de79397c35358745388be433934c203d2b2
-
- Mar 10, 2023
-
-
Chidera Olibie authored
The license file has moved to external/cronet/Android.extras.bp in aosp/2469561 Test: m Change-Id: I2b99de4970a8bf8275195b73b9ad603477bcaf24
-
- Mar 02, 2023
-
-
Mohannad Farrag authored
* cc_objects are more like source-sets. However, they are not commonly used in AOSP which makes it risky to rely on them. * Clang native code coverage is not working for cc_objects. Which is needed for the dashboard. Size Delta to .SO x64: -0.1MB x86: 0MB arm: 0MB arm64: 0MB Test: m Bug: 270027426 Change-Id: I1d74e0293dac91334bded73b0e89465b7af7480c
-
- Feb 27, 2023
-
-
Mohannad Farrag authored
Test: mma Change-Id: Ia195d7d8505933167478c2f7c116709e1d17a31f
-
- Feb 22, 2023
-
-
Mohannad Farrag authored
desc_*.json has been overwritten by https://android-review.git.corp.google.com/c/platform/packages/modules/Connectivity/+/2429636/5 Test: None Change-Id: I4ffc7c9fa48aaf8f9842871b5d07f69eaeeaeeea
-
Mohannad Farrag authored
* The generated desc_*.json files except the compiling(not target) cpu architecture to be x64. which was an issue because Soong tries to compile for both x32 and x64. Test: mma Change-Id: I6be5ed045a25e4020e69bf0157f919f43e68e2c0
-
Mohannad Farrag authored
* Stem should be the name of the target under GN build system as this is the one expected in the source code as seen here https://source.chromium.org/chromium/chromium/src/+/main:components/cronet/android/test/javatests/src/org/chromium/net/CronetTestRule.java;l=244?q=loadLibrary%5C(%5C%22cronet_tests&ss=chromium%2Fchromium%2Fsrc Test: None Change-Id: I758b9b265d0187c93b4fc8ab48491cc5f7a5a750
-
Mohannad Farrag authored
Test: None Change-Id: Ib7cd19697ac39362cc67ad97e4c6bcf1c516e287
-
Mohannad Farrag authored
* Most of the genrules doesn't affect the JNI/jajar. Only genrules that uses the following scripts must be jarjared * //base/android/jni_generator/jni_generator.py * //base/android/jni_generator/jni_registration_generator.py Test: None Change-Id: I2f750e151002b8b21fa2bfd557ad1bbaf5110dff
-
Mohannad Farrag authored
* The current testing situation for Cronet is dire due to the presence of Cronet on the platform, As cronet is on the platform, we can't run any unit-tests as they'll link against the platform version and not the statically-linked cronet. We could avoid this by jarjaring the code however this is impossible. * It's impossible to jar-jar the code as the C++ code which does JNI expects jar-jared java classes. So the only possible solution here would be to duplicate the C++ modules, one for testing(with no jarjar) and another for platform(with jarjar) * Java sources/actions are not collected for testing modules until a proper solution has been figured out. Test: None Change-Id: I20bbad13d83e9e3c7956f028f3f0493b24d0f8bc
-
Mohannad Farrag authored
Test: none Change-Id: I72a2a23021b01bbf7a78fd458405340349503ea5
-
Mohannad Farrag authored
* This is a test suite containing 90 unit tests which passes currently on AOSP. using a custom test runner that will be pushed in upcoming commits Test: m Change-Id: Ifa2aa82c5a36ab5b5f9f91dc52dfe803a429a074
-
Mohannad Farrag authored
Test: m Change-Id: I549d78baf94b1abec07782df006269ba00e2776c
-
Mohannad Farrag authored
* Tests usually shim memory allocations for metrics purposes through linker flags. Test: m Change-Id: I2a3bbe648f155469721cf1df25439ca60afee6b5
-
Mohannad Farrag authored
Test: m Change-Id: Id48dabf893fb7dc7698973f8d52a802134d77e82
-
Mohannad Farrag authored
* The cmd of the `cc_genrule` is now arch-dependent. So we no longer generate a genrule for each arch. The propagation of the arch-dependent genrule was broken due to an old if-statement. Test: m Change-Id: I4b9b522c429f32fe74d141b00bd856f6c39498d7
-
Mohannad Farrag authored
* This is a python script that runs a binary on files to generate output files for testing. * The python script is not really needed as we can run the binary right away. Test: m Change-Id: I3be64e7f51380f2c028dec3168c924451076db95
-
Mohannad Farrag authored
* Aidl `local_include_dirs` was hardcoded. This change should handle extracting the srcs and local include dirs for any aidl action. Test: m Change-Id: I7893dd3897f292f96c1934b192d20b97c26c54cb
-
Mohannad Farrag authored
Test: TH Change-Id: I66bbbb17446ea1f87e07b3d63d2c4e1ffa9d1a51
-
- Feb 13, 2023
-
-
Motomu Utsumi authored
Bug: 265913942 Test: ./update_results.sh Change-Id: I264449b31972e963e7833b0647d5f0634e92756f
-
Motomu Utsumi authored
Update gen_desc_json to use the same args.gn with release build job args.gn was taken from following build job https://ci.chromium.org/ui/p/chrome/builders/ci/cronet-arm/13133/overview https://ci.chromium.org/ui/p/chrome/builders/ci/cronet-arm_64/13142/overview https://ci.chromium.org/ui/p/chrome/builders/ci/cronet-x64/13110/overview https://ci.chromium.org/ui/p/chrome/builders/ci/cronet-x86/13106/overview Update desc json and Android.bp following args.gn update. Bug: 265913942 Test: ./update_results.sh Change-Id: I676431180e9d25e75612c84b6ce6c03585aed1af
-
- Feb 10, 2023
-
-
Mohannad Farrag authored
nss_certs are only used for host net unittestings. Android.bp is not affected because the tests are not pulled-in yet. Test: None Change-Id: Idef23174d1ecd89c2db90318bfb0cf67a4e70145
-