Skip to content
Snippets Groups Projects
  1. Mar 29, 2023
  2. Mar 24, 2023
    • Mohannad Farrag's avatar
      gn2bp: Turn off `allocator_shims` for musl only · 8c5b578a
      Mohannad Farrag authored
      * I've investigated turning off `allocator_shims` globally for all of Cronet but
      this didn't sound like a good option. allocator_shims are used for security measures,
      where sometimes malloc caller forget to check for NULL which happens on oom. allocator_shims would
      instantly kill the app instead of depending on the caller to do the validity check.
      * The solution here was to manually remove the files and add them to `android` and `glibc` only so allocator_shims
      is never compiled for musl.
      * Chromium does not support musl so there's no flag for `musl` with allocator_shims.
      
      Test: mma
      Change-Id: I2a63b14482a526d06a089647e6f61eea9f1691dc
      8c5b578a
  3. Mar 23, 2023
  4. Mar 20, 2023
  5. Mar 14, 2023
  6. Mar 13, 2023
    • Stefano Duo's avatar
      gn2bp: Add an helper to drop unneeded third_party dependencies · f5954480
      Stefano Duo authored
      Use a more expressive always_disable function to disable unneeded
      third_party dependencies.
      
      Test: Android.bp.swp output is equivalent
      Change-Id: Ib21646dfa076fc6f745b7871851744d6ed18eaf3
      f5954480
    • Stefano Duo's avatar
      gn2bp: Drop upstream boringssl build rules in favor of local Android.bp · 170dc8e8
      Stefano Duo authored
      Due to AOSP's FIPS requirements, AOSP-Cronet's BoringSSL must be
      built differently than Chromium-Cronet's BoringSSL. The downstream way
      of building BoringSSL is manually mantained in
      //external/cronet/third_party/boringssl. So, whenever a target depends
      on upstream's boringssl translate that to the downstream custom target.
      
      Test: m && CtsNetHttpTestCases
      Change-Id: I34a69de79397c35358745388be433934c203d2b2
      170dc8e8
  7. Mar 10, 2023
  8. Mar 02, 2023
    • Mohannad Farrag's avatar
      gn2bp: Convert cc_objects to cc_static_library · 379d79d1
      Mohannad Farrag authored
      * cc_objects are more like source-sets. However, they are not commonly used in AOSP which makes it risky to rely on them.
      * Clang native code coverage is not working for cc_objects. Which is needed for the dashboard.
      
      Size Delta to .SO
      x64: -0.1MB
      x86: 0MB
      arm: 0MB
      arm64: 0MB
      
      Test: m
      Bug: 270027426
      Change-Id: I1d74e0293dac91334bded73b0e89465b7af7480c
      379d79d1
  9. Feb 27, 2023
  10. Feb 22, 2023
  11. Feb 13, 2023
  12. Feb 10, 2023
  13. Feb 09, 2023
Loading