Skip to content
Snippets Groups Projects
Select Git revision
  • test
  • fifteen-qpr0-new
  • fifteen default
3 results
Search by author
  • Any Author
  • Farzin Kazemzadeh Farzin Kazemzadeh itisFarzin
1 author
  1. Jun 22, 2024
  3. Jun 10, 2024
  5. Jun 09, 2024
    • luka177's avatar
      UEventObserver: ignore uevents without name · ca6b5bb8
      luka177 authored and Erfan Abdi's avatar Erfan Abdi committed 
      * Fix for NPE on broken uevents causing soft reboot

E AndroidRuntime: *** FATAL EXCEPTION IN SYSTEM PROCESS: UEventObserver
E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.contains(java.lang.CharSequence)' on a null object reference
E AndroidRuntime:   at com.android.server.policy.PhoneWindowManager$HdmiVideoExtconUEventObserver.parseState(PhoneWindowManager.java:7667)
E AndroidRuntime:   at com.android.server.policy.PhoneWindowManager$HdmiVideoExtconUEventObserver.parseState(PhoneWindowManager.java:7633)
E AndroidRuntime:   at com.android.server.ExtconStateObserver.onUEvent(ExtconStateObserver.java:56)
E AndroidRuntime:   at com.android.server.ExtconUEventObserver.onUEvent(ExtconUEventObserver.java:63)
E AndroidRuntime:   at android.os.UEventObserver$UEventThread.sendEvent(UEventObserver.java:217)

Change-Id: I17711b0af41f4e7cd2ad57d242e1bdd209635622
      ca6b5bb8
  7. Jun 07, 2024
  9. Jun 03, 2024
  11. May 23, 2024
  13. May 21, 2024
  15. May 18, 2024
    • Dhina17's avatar
      SystemUI: tuner: Migrate to M3 switch · d3282d18
      Dhina17 authored and Dhina17's avatar Dhina17 committed 
      Tuners are being used within the settings so the switch style
should match with the settings.

Change-Id: I27fe9aae965b0d748981f18f914ab52530337ca5
      d3282d18
    • Nick's avatar
      fixup! SystemUI: tuner: navbar tuner refresh · 6112aca9
      Nick authored 
      Change-Id: I82aaa8d5d44e5acecdd83947b31222f3d47ba5e9
      6112aca9
    • Dmitry Muhomor's avatar
      fix DevicePolicyManager#logoutUser() never succeeding · 1bf34183
      Dmitry Muhomor authored and Nick's avatar Nick committed 
      To succeed, userId to switch to needs to be set with setLogoutUserIdLocked(), but this is not done
in both callers of this method (both of which are "End session" buttons), making them no-ops.

Change-Id: I47126611632f625edf49c0818df64e7b3e6a578e
      1bf34183
    • Dmitry Muhomor's avatar
      appops: skip ops for invalid null package during state serialization · 1665e92d
      Dmitry Muhomor authored and Nick's avatar Nick committed 
      There's a bug that leads to construction of ops for invalid null package name.
Package name should always be non-null, it's defined and treated as such in AppOpsService.
It being null leads to crashes in system_server when appops state is serialized.

Previous commit reverted a buggy workaround for this bug, add a new workaround to prevent these
crashes.

Change-Id: I5262a347adebf73167e63a5314ca0941d8e39e2c
      1665e92d
    • Dmitry Muhomor's avatar
      Revert "Null safe package name in AppOps writeState" · d2431210
      Dmitry Muhomor authored and Nick's avatar Nick committed 
      This reverts commit 0b925d4f.

Reverted commit introduced a bug:
it skipped the "pkg" tag for ops with null package name.
This meant that ops with null package name were serialized differently than ops with non-null
package name.
Tag hierarchy became the following:
for non-null package name ops: "pkg" -> "uid" -> "op" -> "st"
for null package name ops: "uid" -> "op" -> "st"

Uid ops have the same first two tags as null package name ops started to have:
"uid" -> "op". (refer to the loop over uidStatesClone elements above).

This led to type confusion during deserialization that happens in readState():
null package name ops were deserialized as uid ops, through readUidOps() instead of through
readPackage().

Uid ops are serialized differently than uid element inside package ops, specifically the latter
skips the op mode ("m") attribute when the op mode is at its default value.

Op mode attribute is read unconditionally in readUidOps(), which led to
XmlPullParserException: Missing attribute "m"
exception.

This exception is caught in readState(), and is handled by discarding all deserialized state,
which meant that all appops got reset to their default values.

Subsequent commit adds skipping of ops with null package name during serialization:
they are invalid, package name is defined and treated as @NonNull in multiple places.
Such ops are being constructed due to another bug.

Change-Id: I8b13b8f0979a6daff2db33a1b8e8544dd9e8e531
      d2431210
    • Ido Ben-Hur's avatar
      SystemUI: Nuke oriented navbar handle · 6825f9f0
      Ido Ben-Hur authored and Abdulwahab Isam's avatar Abdulwahab Isam committed 
      AKA fake navbar
AGAIN!!! For the 3rd time. This ain't working dear google.
Not even getting better with their attempts.
I gave up hope on this, I don't see it ever coming back.
Adapted (lazily) to A13, A14

Includes but not limited to these reverts (much code changed to make it work properly):

Revert "Prevent secondary home handle from handling touches"

This reverts commit d05ad989.

Revert "Sample region under secondary home handle"

This reverts commit d2fe92fb.

Revert "Add ID to secondaryOrientationHandle for tests"

This reverts commit 83308950.

Revert "Show secondary home handle in immersive apps"

This reverts commit 9c84ea1f.

Revert "Draw a fake home handle during QuickSwitch"

This reverts commit 63e92bc0.

Revert "Draw a fake home handle during QuickSwitch"

This reverts commit 63e92bc0.

Change-Id: I8e632bb640678bc28eff2b3bfb0a869dd7b31c0c
      6825f9f0
  17. May 17, 2024